cloud-sdk-js icon indicating copy to clipboard operation
cloud-sdk-js copied to clipboard
verified publisher icon SAP

feat: Remove XSUAA binding dependency from destination retrieval flow

Open KavithaSiva opened this issue 7 months ago • 3 comments

Closes SAP/cloud-sdk-backlog#1274.

Changes have been tested manually in an E2E test, I used both an user IAS JWT and user XSUAA JWT to test destination(s) retrievals.

Working E2E test run: https://github.tools.sap/cloudsdk/sdk-js/actions/runs/15330543 with a canary release of these changes.

KavithaSiva avatar Jun 23 '25 07:06 KavithaSiva

@deekshas8 @jjtang1985 I also removed the JWT verification step while trying to fetch a destination(as it is relying on XSUAA binding). This is a behaviour change,please let me know if the change is okay and approved by you.

KavithaSiva avatar Jun 23 '25 14:06 KavithaSiva

Before merging this, it would be nice if we create an E2E test that fails on the current release and passes on this PR / canary.

ZhongpinWang avatar Jun 24 '25 09:06 ZhongpinWang

Before merging this, it would be nice if we create an E2E test that fails on the current release and passes on this PR / canary.

Yes, as discussed, already working on the E2E test. But, I don't think we need to wait for the E2E test to merge this as I already tested the changed manually in an E2E test.

KavithaSiva avatar Jun 24 '25 09:06 KavithaSiva