cloud-sdk-js icon indicating copy to clipboard operation
cloud-sdk-js copied to clipboard

@sap-cloud-sdk/mail-client: Allow OnPremise MAIL destinations without basic authentication so that no user and password is required

Open gregorwolf opened this issue 1 year ago • 2 comments

Is your feature request related to a problem? Please describe.

OnPremise mail servers might not need any authentication. But with the check in mail-client/src/mail-client.ts#L82 it is currently mandatory to provice a user and password by setting the MAIL destination to the Authentication type BasicAuthentication and maintaining User and Password.

Describe the solution you'd like

At least for destination of Proxy Type OnPremise the @sap-cloud-sdk/mail-client should allow destinations where Authentication is set to NoAuthentication.

Describe alternatives you've considered

The configuration of the internal mailserver can't be changed quickly.

Impact / Priority

Affected development phase: Production

Impact: Impaired

Additional context

Same customer as in #5015 is impacted.

gregorwolf avatar Oct 30 '24 20:10 gregorwolf

Hi @marikaner / @ZhongpinWang,

can one of you please review?

gregorwolf avatar Nov 04 '24 08:11 gregorwolf

Hi @marikaner / @ZhongpinWang,

can one of you please review?

Hi @gregorwolf , sorry for the delay, and thanks a lot for your contribution. I left some comments in your PR.

ZhongpinWang avatar Nov 06 '24 15:11 ZhongpinWang