cloud-sdk-java icon indicating copy to clipboard operation
cloud-sdk-java copied to clipboard

Add comment about `ConnectionManager` cardinality in `AbstractHttpClientFactory`

Open newtork opened this issue 1 year ago • 0 comments

I was wondering why this was part of the HttpClientWrapper, when I realized - most likely we do not and cannot reuse connection manager between multiple instances of HttpClient:

https://github.com/SAP/cloud-sdk-java/blob/f0dd44016892ef1f1fbd758b83c84d00948f9854/cloudplatform/connectivity-apache-httpclient4/src/main/java/com/sap/cloud/sdk/cloudplatform/connectivity/HttpClientWrapper.java#L38-L48

To address this in the source code, I want to add a comment.

newtork avatar May 16 '24 08:05 newtork