sc-controller icon indicating copy to clipboard operation
sc-controller copied to clipboard
verified publisher icon Ryochan7

Fix input tester in the gui for all steam deck controls

Open Dark3clipse opened this issue 2 years ago • 6 comments

I noticed that the input tester functionality was only half working on the steam deck. The right stick didn't show as well as some grips, dot button, and the dpad.

This PR attempts to fix this.

steam-deck-input-test-fix.webm

Dark3clipse avatar Jul 12 '23 23:07 Dark3clipse

It seems dpad was not supported for other controllers as well. I will do some further testing with other controllers, I think I need to make the code more compatible before it can be merged.

Dark3clipse avatar Jul 14 '23 14:07 Dark3clipse

I make the dpad test area configurable in the controller svg files and added it to ds5 and deck svgs. I only have those two controllers. Also, there was a bug in enable_test_mode when switching active controller. I made a fix for this.

A further improvement: it seems the input tester does not apply deadzones, resulting in the tester being visible in the center of the stick even when you have set a deadzone. I probably need some help to know how to solve this.

Dark3clipse avatar Jul 21 '23 15:07 Dark3clipse

This cannot be merged as is. This commit breaks the GUI for Steam Controller mapping. It breaks mainly when it comes to the back grip buttons. Hopefully I will be able to take a look and see if something small can be changed to fix those buttons.

Ryochan7 avatar Jul 26 '23 13:07 Ryochan7

Looks like the GUI is actually wrong (at least the icons) in your video as well.

Ryochan7 avatar Jul 26 '23 13:07 Ryochan7

I don't have a steam controller to test with. What part exactly of the gui is wrong?

Im on vacation right now. Ill continue working on this when i am back home

Dark3clipse avatar Jul 27 '23 17:07 Dark3clipse

Long time. Anyway, here is a small demo showing what I was talking about. LGRIP, RGRIP, Left Touchpad, and Right Touchpad use the wrong icon graphics although they are still linked to the correct inputs when opening the action editor. The original python3 interface is also shown for comparison.

The errors in the changed interface are as follows. LGRIP input uses the RGRIP icon graphic. RGRIP input uses the Left Touchpad icon graphic. Left Touchpad input uses the Stick icon graphic. Right Touchpad input uses the Left Touchpad icon graphic.

https://github.com/Ryochan7/sc-controller/assets/581968/2cf20724-1b75-42a4-b71c-072b89d54886

Ryochan7 avatar Nov 08 '23 03:11 Ryochan7