Ryan Tate

Results 18 comments of Ryan Tate

Thanks @sebastinez! I think a custom derive would be great for this. I'll work toward an implementation and continue to review the other libraries mentioned in the thread.

@sebastinez @cloudhead getting closer to having Eip712 derive merged into ethers-rs-- opened a draft PR https://github.com/gakonst/ethers-rs/pull/481 for early feedback. Still have to work on test coverage and verify accuracy against...

Quick update on the [Eip712](https://github.com/gakonst/ethers-rs/pull/481#issuecomment-934717008) derive macro. Getting closer to landing it.

Appears to be breaking on https://github.com/infinyon/node-bindgen/blob/master/nj-core/src/basic.rs#L348 when attempting to convert the napi result in the `napi_call_result!` macro on https://github.com/infinyon/node-bindgen/blob/master/nj-core/src/lib.rs#L67 `napi_get_cb_info` signature looks good. Checking if there have been breaking changes.

#75 Includes a solution for this.

It looks like this might be achievable using https://nodejs.org/api/n-api.html#n_api_napi_create_async_work [feature/async](https://github.com/infinyon/node-bindgen/blob/feature/async/nj-core/src/async_work.rs) branch has a work in progress on implementation. Not sure when the work will be completed, but wanted to post...

> * Also commenting on the formatting/style churn. I assume that was from some editor automation? > * Looks like maybe a couple lines do a useful change from errant...

@ottonomy @davidlehn I ran eslint against the project and resolved the linting errors. I still see formatting changes to the .vue exchange layout file, maybe there is another linter for...