EntityFrameworkCore.UseRowNumberForPaging icon indicating copy to clipboard operation
EntityFrameworkCore.UseRowNumberForPaging copied to clipboard
verified publisher icon Rwing

Restore previous convert visitor approach to correctly bind columns

Open Vogel612 opened this issue 11 months ago • 2 comments

Instead of attempting to get away without using reflection (and then resorting to it anyways), this setup reuses the previously used approach to updating the SelectExpression. Due to internal changes that means a slightly different invocation of the GenerateOuterColumnAccessor preceded by a reflection-based restoration of the _sqlAliasManager that is needed for the call of PushDownIntoSubQuery. Future versions of .NET may make this obsolete by removing the use of SqlAliasManager within SelectExpression entirely, but that's a future concern.

This fixes both the projection behavior of Net9 as well as non-root offset and limit uses for net8 as introduced in #17. @Rwing sorry it took so long to get this fix done...

Vogel612 avatar Jan 27 '25 10:01 Vogel612

@Rwing Do you have time to merge this PR?

tonyqus avatar Apr 06 '25 23:04 tonyqus

any update?

tonyqus avatar Jun 13 '25 10:06 tonyqus