tensorboard_logger icon indicating copy to clipboard operation
tensorboard_logger copied to clipboard

file INSTALL cannot find on Windows

Open ChikaYan opened this issue 3 years ago • 2 comments

Hi,

Thank you for this great package! I'm trying to follow the readme to compile and install it on a Windows machine, however, I'm getting errors during the install stage.

Namely, I followed:

> BUILD_DIR=build
> mkdir -p $BUILD_DIR && cmake -B $BUILD_DIR . && cmake --build $BUILD_DIR -j
> cmake --install $BUILD_DIR

Which runs file for --build (although I got a bunch of warnings such as warning C5045: Compiler will insert Spectre mitigation for memory load if /Qspectre switch specified from this package and warning C4514: 'google::protobuf::Descr iptor::reserved_range_count': unreferenced inline function has been removed from protobuf). However, when I try to run cmake --install $BUILD_DIR, I got:

-- Install configuration: "Release"
CMake Error at build/cmake_install.cmake:39 (file):
  file INSTALL cannot find
  "C:/nonsys/workspace/tensorboard_cpp/build/Release/tensorboard_logger.lib":
  No error.

It seems to be a badly phrased error message relating to the install command in cmakelist (https://gitlab.kitware.com/cmake/cmake/-/issues/19950) but I'm not sure how to resolve it.

Moreover, when trying to compile with the tests via:

> BUILD_DIR=build
> mkdir -p $BUILD_DIR && cmake -DBUILD_TEST=ON -B $BUILD_DIR . && cmake --build $BUILD_DIR -j
> mkdir -p demo && ./$BUILD_DIR/tensorboard_logger_test

I got many errors like this:

tensorboard_logger.lib(projector_config.pb.obj) : error LNK2001: unresolved external symbol "class google::protobuf::i
nternal::ExplicitlyConstructed<class std::basic_string<char,struct std::char_traits<char>,class std::allocator<char> >
 > google::protobuf::internal::fixed_address_empty_string" (?fixed_address_empty_string@internal@protobuf@google@@3V?$
ExplicitlyConstructed@V?$basic_string@DU?$char_traits@D@std@@V?$allocator@D@2@@std@@@123@A) [C:\nonsys\workspace\tenso
rboard_cpp\build\tensorboard_logger_test.vcxproj]
C:\nonsys\workspace\tensorboard_cpp\build\Debug\tensorboard_logger_test.exe : fatal error LNK1120: 1 unresolved extern
als [C:\nonsys\workspace\tensorboard_cpp\build\tensorboard_logger_test.vcxproj]

May I ask what version of protobuf are we supposed to use?

Many thanks!

ChikaYan avatar Feb 05 '23 01:02 ChikaYan

No specific version of protobuf is required, and I have used many versions since the beginning of this project without such issue.

I have no Windows development environment currently, and I'm not familiar with the development process 😂 It will take me some time to reproduce and fix the problem.

RustingSword avatar Feb 06 '23 12:02 RustingSword