rust-jack icon indicating copy to clipboard operation
rust-jack copied to clipboard

Uncomment jack_set_port_rename_callback() since it seems to work

Open xkr47 opened this issue 2 years ago • 1 comments

Comment suggested "doesn't compile for testing since it is a weak export" but I was able to compile and run tests just fine. I have Linux / Devuan with jack2 (not pipewire).

A few tests were failing, but commenting or uncommenting the code did not affect the outcome.

I changed this since I maintain a program to automatically update connections based on which (jack) clients and ports are present and I noticed Ardour seems to rename ports.. and I would prefer to not having to request a full list of ports and connections on every event..

Thanks for your great lib!

xkr47 avatar Aug 13 '23 16:08 xkr47

For the record, I checked all the build errors and all of them are "remove this call to default". A lot of them are AudioIn::default(), which is also the documented way of producing an AudioIn. So it seems to me that the correct remedy to this would be to add #![allow(clippy::default-constructed-unit-structs)] in the right places. Wdyt? I can look into creating a separate PR if you like.

xkr47 avatar Aug 24 '23 17:08 xkr47