rodio icon indicating copy to clipboard operation
rodio copied to clipboard

Clear and skip

Open ChiefMilesEdgeworth opened this issue 5 years ago • 3 comments

This PR still has some room for work, but this gives basic functionality for clear()ing and skip_one()ing Sinks. This seems like very useful functionality, and helps make the library more accessible.

There's also some simple formatting stuff done here, since cargo-fmt didn't work when I was using it due to an error in the .rustfmt.toml file. That's a simple enough to change to something else if need be :)

Closes? #171

ChiefMilesEdgeworth avatar May 14 '20 20:05 ChiefMilesEdgeworth

Just saw a different PR where there was a comment to not fix cargo-fmt in a PR that does functionality. I'm reverting the commit that ran cargo-fmt.

ChiefMilesEdgeworth avatar May 14 '20 20:05 ChiefMilesEdgeworth

Please for the love of god merge this! I'm really needing this basic functionality!

tralph3 avatar Nov 23 '21 04:11 tralph3

I tested this clear function, but after clear, the player will always generate an alsalib buffer underrun warning. Without clear it's no problem. my code is in https://github.com/tramhao/termusic/tree/dev/src .

tramhao avatar Jun 06 '22 04:06 tramhao

Is there any status on this? If there's a blocker somewhere, I'm willing to lend a hand in any way I can. This functionality seems essential to a library like this.

ivakam avatar Sep 14 '22 12:09 ivakam

First there is this:

This PR still has some room for work

I'm not sure exactly what there is left.

Also, a rebase is needed. And of course a proper review.

est31 avatar Sep 14 '22 12:09 est31

I think it's been too long since I first put this together, so if someone else wants to take this branch and run with it I would welcome them to it. I'm going to close this PR though.

ChiefMilesEdgeworth avatar Sep 14 '22 12:09 ChiefMilesEdgeworth

This PR is continued by me in #442.

ivakam avatar Sep 14 '22 14:09 ivakam