cpal icon indicating copy to clipboard operation
cpal copied to clipboard

Replace stdweb with wasm-bindgen, js-sys, and web-sys

Open brightly-salty opened this issue 5 years ago • 6 comments

Replaces stdweb (which is unmaintained) with a combination of wasm-bindgen, and js-sys web-sys (which are). Fixes #518.

brightly-salty avatar Dec 09 '20 00:12 brightly-salty

@mitchmindtree

This is now ready for review. I strongly recommend to squash while merging due to the many failing commits. Let me know if you need me to do anything else.

brightly-salty avatar Dec 11 '20 23:12 brightly-salty

There is a build failure.

est31 avatar Nov 15 '21 06:11 est31

Yeah, I need to get back into the code and actually fix the merge conflict. I'm not sure why the ios build fails though

brightly-salty avatar Nov 15 '21 14:11 brightly-salty

ios fails on master too, so it's not a regression of this PR, so there is no requirement to fix it in here.

est31 avatar Nov 15 '21 15:11 est31

@brightly-salty Is there anything left in this PR that you consider unfinished? I look forward to merging this PR soon if there are no known issues, given that asmjs CI appears to be broken on master.

ishitatsuyuki avatar Mar 18 '22 07:03 ishitatsuyuki

@ishitatsuyuki I'll look into it, but if I remember correctly there was some functionality in main that couldn't be fully matched with the replacement library.

brightly-salty avatar Mar 18 '22 17:03 brightly-salty

This issue would probably fix the asmjs-wasm32 checks

mbodmer avatar Oct 20 '22 15:10 mbodmer

The PR also needs a rebase. It's a good idea, and I like the direction of it.

est31 avatar Oct 20 '22 18:10 est31

If there is still interest in this PR in general, the rebase would be very messy I think. It might be easier to close this and start over with the newest versions of the replacement crates, since they probably have newer functionality I couldn't take into account 2 years ago.

brightly-salty avatar Oct 22 '22 00:10 brightly-salty

Okay let's close this then :+1: .

est31 avatar Oct 22 '22 01:10 est31