gccrs icon indicating copy to clipboard operation
gccrs copied to clipboard

borrowck: Added location support to BIR nodes

Open braw-lee opened this issue 1 year ago • 2 comments

Added location field to BIR::Statement and BIR::Place, updated the BIR builders to take the source location from HIR and pass it to BIR node.

braw-lee avatar May 20 '24 10:05 braw-lee

should I work on my branch the whole time, and you can merge it after 2-3 months? or should I just create new PRs whenever I get something done and you will merge those from time to time? @CohenArthur @P-E-P

braw-lee avatar May 21 '24 08:05 braw-lee

should I work on my branch the whole time, and you can merge it after 2-3 months? or should I just create new PRs whenever I get something done and you will merge those from time to time? @CohenArthur @P-E-P

Actually it would be better to merge your content quite often. This way other contributors can follow your work and can work over it. Moreover it'll be easier to review and you won't have to make huge rebase.

We may be a little slow to merge some PRs sometime because reviewing them take some time. You may create some PRs on top of another with the mention "Requires #PRNUMBER", you may even put a link to the actual diff just like in #3014. If you do so please keep those PR in draft whilst it's dependencies are not merged so they don't end up merged.

P-E-P avatar May 21 '24 08:05 P-E-P

This needs to be rebased as well @braw-lee

CohenArthur avatar Jul 16 '24 15:07 CohenArthur