virtualhost icon indicating copy to clipboard operation
virtualhost copied to clipboard

Added the www. alias

Open lombax85 opened this issue 9 years ago • 6 comments

Added a www.* alias to the host. If you create the host site.com, now it can be accessed through site.com and www.site.com

lombax85 avatar Mar 27 '16 20:03 lombax85

Shouldn't you also add a flag in case www is not necessary. Example, in the case that you make a subdomain, would you want www.subdomain.domain.com. Probably not.

tealise avatar Apr 19 '16 17:04 tealise

Personally, the script is not intendend to be used on production, so www is not necessary, already reject PR related with prepend www, probably the use of both could be, thoughs?

RoverWire avatar Apr 19 '16 18:04 RoverWire

Personally I used your script on a production server for non-critic applications (my personal sites) and I think that for this case it fits the need. I agree that I wouldn't use it in a more complex environment. I think that adding the www. would help people who are searching for a rapid way to create ready-to-go virtual hosts on a non critical production environment. I agree too with the other comment that a flag to choose if enable the alias is appropriate, so if you think that the feature can be accepted, I'll do another PR with a specific flag to enable the alias. Let me know

lombax85 avatar Apr 20 '16 18:04 lombax85

I think both option would be great, to use domain with/without www prefix

RoverWire avatar Aug 15 '16 19:08 RoverWire

Hi, I added an optional parameter for adding the virtual alias (not only www, you can choose which alias you want to use) and updated the readme. Moreover, I fixed an issue with nginx directory configuration. I didn't made another pull request for that since my feature was dependent on that fix. Let me know if it is ok now.

lombax85 avatar Oct 17 '16 09:10 lombax85

Please see my update on your previous comment here

lombax85 avatar Dec 03 '16 13:12 lombax85