PlayerParticles icon indicating copy to clipboard operation
PlayerParticles copied to clipboard

Vanish support

Open LeonMangler opened this issue 2 years ago • 0 comments

Hello, I'm the dev of the SuperVanish and PremiumVanish plugins and I have heard from a customer that the vanish integration of PlayerParticles may not be working. I checked the source code and am wondering if perhaps you forgot to add a negation at the end of the isPlayerVisible check. Currently it seems like players would be considered visible rather than invisible when the vanished metadata is present.

Here's the line I'm looking at: https://github.com/Rosewood-Development/PlayerParticles/blob/c680a2bf9797b0434b702fbe427a5a1fea1e0f3f/src/main/java/dev/esophose/playerparticles/util/ParticleUtils.java#L161

In case it is indeed a mistake I would be really thankful if it could be fixed!

LeonMangler avatar Oct 21 '23 04:10 LeonMangler