rosetta icon indicating copy to clipboard operation
rosetta copied to clipboard

Remove is_surface() from Residue/ResidueType.

Open roccomoretti opened this issue 1 year ago • 1 comments

This function is confusing, as it's not talking about the surface of a protein, but mineral surfaces.

The ResidueType property SURFACE isn't used frequently -- for the rare case it's needed, we can use the more involved query protocol, rather than leaving the potentially confusing Residue::is_surface() lying around.

roccomoretti avatar Sep 12 '24 15:09 roccomoretti

Looks good to me. (One option would be to rename to is_type_surface())

ajasja avatar Sep 19 '24 09:09 ajasja