obsidian-api-request icon indicating copy to clipboard operation
obsidian-api-request copied to clipboard

`req-repeat` and `properties` together halt execution after first

Open raphaklaus opened this issue 1 year ago • 4 comments

Example:

url: http://localhost:3001/price/{{this.ticker}}
show: current_price,last_price_updated_at
properties: current_price,last_price_updated_at
req-repeat: 1000@5

After the first execution, which returns (see here), the loop exits and the properties variable loses its reference, not updating the properties and neither continuing the request repeat logic.

I managed to fix this issue in a local branch just to unblock my work, but that was a nasty fix. Honestly, we would have to figure out how to refactor this plugin because it's becoming hard to build upon from what I saw. Let me know if you want to collab on that.

raphaklaus avatar Oct 29 '24 21:10 raphaklaus

Hello @raphaklaus, I've had the idea of redoing this plugin for a while now but I haven't found the time or motivation to undertake the task. Maybe with your help we can give a new life to this plugin. Thank you.

Rooyca avatar Oct 30 '24 03:10 Rooyca

I believe it would be a good idea to do a list with all the features we want (or not) to support. Because the biggest problem with this plugin is that tried to do many things and end up doing them all poorly.

Rooyca avatar Nov 22 '24 00:11 Rooyca

Right. What is the core motivation of this plugin? I mean, what problem(s) did you have in mind when writing it?

raphaklaus avatar Dec 09 '24 15:12 raphaklaus

At the beginning this plugin was only intended to make simple GET requests, but over time I added functionalities (maybe not in the best way) that, at the time, seemed interesting to me. Now I don't know which features we should leave and which we should remove, that's why I could use some help.

Rooyca avatar Jan 21 '25 15:01 Rooyca