Icon Cleanup

[Jeremy-Walton]

Task

TR #126

Why?

Icon classes were implemented before some of the scale patterns found in other components were established. Additionally, there were some cases of needing to force an icon style from another component. Rather than duplicate properties, Adding more placeholder selectors allows extending without duplicating.

What Changed

• [X] Refactor icon implementation to match api naming patterns
• [X] Refactor icon to use placeholder selector pattern
• [X] Make placeholder selectors for size and weight properties of icon to allow overriding from a parent component.

Sanity Check

• [X] Have you updated any usage of changed tokens?
• [X] Have you updated the docs with any component changes?
• [X] Have you updated the dependency graph with any component changes?
• [X] Have you run linters?
• [X] Have you run prettier?
• [X] Have you tried building the css?
• [X] Have you tried building storybook?
• ~~Do you need to update the package version?~~

[Jeremy-Walton]

Icon Revisions

[Jeremy-Walton]

Note: This PR is on hold since it technically introduces breaking changes.

This does clean up icon usage significantly and doesn't change the usage (names of classes), but it does affect anyone who is overriding or customizing their icon classes.