Results 46 comments of Rogdham

> No message and the login button is active in Chrome. Does signing in work in Chrome, or is it also broken, just without notification? Indeed, but when submitting the...

Thank you for the feedback, I have added a test and confirmed that it failed before the fix.

Dammit I completely missed #1173 for some reason, this would have saved me some headache :grimacing: Since their fix looks the same to me, should I just close this PR?...

On second thought, I am not really sure whether this PR is going in the way the gitreceive project should go. Even though I tried to make it small, it...

Thank you so much for your detailed reply, you're awesome! :heart_eyes: So the only thing unclear is the offset in the file index footer, i.e. the very last 8 bytes....

> It would be nice if pixz manpage could clarify, whether or not it's created files (i.e. also those with indexing) are expected to be compatible with the "standard" xz-utils...

> Hm, how will you seek to the last 8 bytes of the file-index without understanding the xz file format? You'll need liblzma (or equivalent) to do that, and once...

The [rename mechanism](https://jcristharif.com/msgspec/structs.html#renaming-field-names) could be probably used for this (from the point of view of the user of the lib), something like this: ```py class Option(msgspec.Struct): x: int foo_names= {...

FYI in urllib3 [a PR](https://github.com/urllib3/urllib3/pull/3022) has been merged using `ZstdDecompressionObj.unused_data` to decompress one frame separately after the other. Moving forward, I personnaly believe the `read_across_frames` being implemented in all methods...

I'm sorry but I have quite no idea (I only know about [a plugin for gedit](https://help.gnome.org/users/gedit/stable/gedit-plugins-modelines.html.en)…) . I can't say that I have a strong opinion on this PR. I...