RocketPy
RocketPy copied to clipboard
ENH: Individual Fin
Pull request type
- [x] Code changes (bugfix, features)
Checklist
- [ ] Tests for the changes have been added (if needed)
- [ ] Docs have been reviewed and added / updated
- [x] Lint (
black rocketpy/ tests/) has passed locally - [ ] All tests (
pytest tests -m slow --runslow) have passed locally - [ ]
CHANGELOG.mdhas been updated (if relevant)
Description
Individual fins have been added to RocketPy:
-
Finclass,TrapezoidalFinclass andEllipsoidalFinclass have been added - A simulation with a fin set is equivalent to building a fin set with individual fins in the correct positions. There are only small differences in roll dynamics, since the roll moment comes directly from the lift force, instead of going through barrowman's calculations of the roll coefficient
Breaking change
- [ ] Yes
- [x] No
Remaining Tasks
- [ ] 1. Add a representation of IndividualFin in the Drawing.
- [x] 2. Create Plots and Prints classes for IndividualFin
- [ ] 3. Fix stability margin calculation for IndividualFin. Add lateral stability analysis. Or add warning saying stability calculations will not work for IndividualFins
- [ ] 3. Pylint
- [ ] 4. Tests
- [ ] 5. Class usage page / example usage
- [ ] 6. Example usage with controllers
It would be truly great to get some help on these minor tasks
Contributors
Special thanks to @kevin-alcaniz and Faraday Rocketry UPV for their contributions!!
Codecov Report
Attention: Patch coverage is 28.98089% with 223 lines in your changes missing coverage. Please review.
Project coverage is 72.26%. Comparing base (
1f2358a) to head (9e7d708). Report is 46 commits behind head on enh/generic-surfaces.
Additional details and impacted files
@@ Coverage Diff @@
## enh/generic-surfaces #686 +/- ##
========================================================
- Coverage 74.91% 72.26% -2.65%
========================================================
Files 87 94 +7
Lines 10308 10899 +591
========================================================
+ Hits 7722 7876 +154
- Misses 2586 3023 +437
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Must be re-opened in the future