MNT: Cleaning the data folder
What I propose is: (soft suggestions)
- [ ] Create a "rockets" folder and save "caldene", "calisto", "euporia", "valetudo" folders inside that
- [ ] Move "jiboia", "keron", "mandioca" to "motors" folder
- [ ] Clean the "weather" folder by removing the majority of files and letting only the crucial ones.
- [ ] Do not duplicate files in tests/fixtures. The best place to save data is the data folder!
- [ ] Organize motors in different subfolders if needed
This issues requires at least a little discussion before starting applying new changes. @giovaniceotto could we help with some insights here?
Great suggestions @Gui-FernandesBR.
I agree that the data folder may no longer be needed. We can move some of the files used for tests to the tests folders as fixtures, and create an sepecific folder for complete example cases, including comparisons with real flight data.
The only point I disagree with is creating a separate repository for examples. While this would make this repository lighter, it would be a nightmare to manage. Imagine having to sync two separate repositories so that the examples can always run with the latest RocketPy version. I do not believe this is worth the effort.
I agree that the data folder may no longer be needed.
Nooo, did I say that? sorry hahahaha Data folder is indeed important. Lot of notebooks are using powerOnDrag='data/calisto/....csv' file, for example. The problem is that the folder is currently a mess.
What I think we could do is:
- Delete the not so useful files in the data folder (#316)
- Keep only necessary files in the tests/fixtures, not duplicating them when the file already exists in the data folder.
- Comparisons, examples cases may be used mainly as documentation. Thus we should add them as notebooks and refer in our docs. The currently
tests\fixtures\acceptance\EPFL_Bella_Lui\bella_lui_flight_sim.pyfile, for instance, could be converted into a jupyter notebook, where we can convert to .rst and add to our docs.