fuselage icon indicating copy to clipboard operation
fuselage copied to clipboard

fix(fuselage): Using Pre Wrap For System Message

Open nishant23122000 opened this issue 3 years ago • 8 comments

Proposed changes (including videos or screenshots)

Before :

Screenshot 2022-11-11 at 12 33 13 AM

After :

Screenshot 2022-11-11 at 12 33 55 AM

reason of change : https://github.com/RocketChat/Rocket.Chat/pull/27080

Issue(s)

Further comments

nishant23122000 avatar Nov 04 '22 19:11 nishant23122000

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Nov 04 '22 19:11 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Nov 04 '22 19:11 CLAassistant

Can you add screenshots so we now how it changed visually? Also a description so we could understand the issue better would help. Thanks!

gabriellsh avatar Nov 10 '22 16:11 gabriellsh

Can you add screenshots so we now how it changed visually? Also a description so we could understand the issue better would help. Thanks!

Done check now

nishant23122000 avatar Nov 10 '22 19:11 nishant23122000

Hey @nishant23122000 ! I'll be checking with design to see if this is the desired UI/UX for this. If we're all in agreement, I'll review the code and merge this.

gabriellsh avatar Nov 11 '22 14:11 gabriellsh

Hello @nishant23122000, José from Rocket.Chat's design team here. I was wondering what prompted your need to work on longer system messages, in our experience they usually are no longer than 4 or 5 words. So we don't actually see a need for this particular improvement.

Either way I'm excited to find a solution to this problem in the coming releases, but this particular one doesn't agree with the spacing standards we set up for the platform. Hope you understand.

jsdgdo avatar Nov 14 '22 14:11 jsdgdo

If words are less than 4 or 5 then it makes sense to don't do these changes.

but I think the agent can write long sentences also in some cases.

nishant23122000 avatar Nov 14 '22 16:11 nishant23122000

The UX problem, IMHO, is that the receiving agent will not have access to that comment in full, which is usually very important for the chat handling.

Isn't there a way to allow that message to be shown, like on mouse hover?

dudanogueira avatar Feb 23 '23 22:02 dudanogueira