Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

chore: Updated federation callout from Alpha to Beta

Open aleksandernsilva opened this issue 2 months ago • 5 comments

Proposed changes (including videos or screenshots)

Screenshot 2025-12-08 at 15 17 21

Issue(s)

FB-125

Steps to test or reproduce

  • Access Workspace > Settings > Federation
  • Should be visible bellow "Enable federation" toggle

Further comments

aleksandernsilva avatar Dec 08 '25 18:12 aleksandernsilva

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Dec 08 '25 18:12 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: ae0692eee9b23833006b66dd7170da49cfec9daa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 08 '25 18:12 changeset-bot[bot]

Walkthrough

Updated Federation service status from Alpha to Beta in English localization, clarifying non-critical deployment readiness, ongoing audits, and the requirement for workspace administrators to grant 'access-federation' permission. Removed the corresponding Norwegian localization entry.

Changes

Cohort / File(s) Summary
Federation Service Alert Localization
packages/i18n/src/locales/en.i18n.json
Updated Federation_Service_Alert text from Alpha feature notice to Beta notice, describing final audits, non-critical deployment readiness, potential intermittent issues, and mandatory 'access-federation' permission requirement for federated room access
Norwegian Localization
packages/i18n/src/locales/nb.i18n.json
Removed Federation_Service_Alert translation key

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

  • RocketChat/Rocket.Chat#37504 — Adds frontend handling and hint keys for the 'access-federation' permission in Create Channel modal, complementing the permission requirement now documented in this localization update.
  • RocketChat/Rocket.Chat#37377 — Adds and enforces the 'access-federation' permission logic that is referenced in the updated Federation_Service_Alert text.
  • RocketChat/Rocket.Chat#37227 — Modifies the same Federation_Service_Alert localization key in the English i18n file.

Suggested labels

stat: QA assured

Suggested reviewers

  • ggazzo

Poem

🐰 From Alpha's young sprint to Beta's embrace, The Federation leaps forward with measured grace. Permissions now granted with admin's swift hand, Our locales adjusted across every land. Though Norwegian steps back, English stands tall, Beta brings readiness—ready for all! ✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The removal of the Norwegian translation string is potentially out of scope; only the English text should have been updated per FB-125 requirements. Restore the Norwegian (nb.i18n.json) translation entry with an appropriate Beta translation for consistency across locales.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: updating the federation callout from Alpha to Beta messaging.
Linked Issues check ✅ Passed The changes implement the Beta callout content exactly as specified in FB-125, with proper English translation and structure.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment
  • [ ] Commit unit tests in branch chore/federation-beta-disclaimer

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 08 '25 18:12 coderabbitai[bot]

📦 Docker Image Size Report

📈 Changes

Service Current Baseline Change Percent
sum of all images 1.2GiB 1.2GiB +12MiB
rocketchat 358MiB 347MiB +12MiB
omnichannel-transcript-service 132MiB 132MiB -176B
queue-worker-service 132MiB 132MiB +60B
ddp-streamer-service 126MiB 126MiB -274B
account-service 113MiB 113MiB +483B
stream-hub-service 110MiB 110MiB -116B
presence-service 110MiB 110MiB +260B
authorization-service 110MiB 110MiB +586B

📊 Historical Trend

---
config:
  theme: "dark"
  xyChart:
    width: 900
    height: 400
---
xychart
  title "Image Size Evolution by Service (Last 30 Days + This PR)"
  x-axis ["11/15 22:28", "11/16 01:28", "11/17 23:50", "11/18 22:53", "11/19 23:02", "11/21 16:49", "11/24 17:34", "11/27 22:32", "11/28 19:05", "12/01 23:01", "12/02 21:57", "12/03 21:00", "12/04 18:17", "12/05 21:56", "12/08 20:15", "12/09 22:17", "12/10 23:26", "12/11 21:56", "12/12 22:45", "12/13 01:34", "12/15 22:31", "12/16 19:43", "12/16 21:11 (PR)"]
  y-axis "Size (GB)" 0 --> 0.5
  line "account-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "authorization-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "ddp-streamer-service" [0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12, 0.12]
  line "omnichannel-transcript-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "presence-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]
  line "queue-worker-service" [0.14, 0.14, 0.14, 0.14, 0.14, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13, 0.13]
  line "rocketchat" [0.36, 0.36, 0.35, 0.35, 0.35, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.34, 0.35]
  line "stream-hub-service" [0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11, 0.11]

Statistics (last 22 days):

  • 📊 Average: 1.5GiB
  • ⬇️ Minimum: 1.2GiB
  • ⬆️ Maximum: 1.6GiB
  • 🎯 Current PR: 1.2GiB
ℹ️ About this report

This report compares Docker image sizes from this build against the develop baseline.

  • Tag: pr-37727
  • Baseline: develop
  • Timestamp: 2025-12-16 21:11:30 UTC
  • Historical data points: 22

Updated: Tue, 16 Dec 2025 21:11:30 GMT

github-actions[bot] avatar Dec 08 '25 18:12 github-actions[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 67.74%. Comparing base (f3dc2c1) to head (ae0692e). :warning: Report is 39 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #37727      +/-   ##
===========================================
+ Coverage    67.63%   67.74%   +0.11%     
===========================================
  Files         3457     3460       +3     
  Lines       113662   113842     +180     
  Branches     20903    20961      +58     
===========================================
+ Hits         76874    77127     +253     
+ Misses       34657    34589      -68     
+ Partials      2131     2126       -5     
Flag Coverage Δ
e2e 57.29% <ø> (+<0.01%) :arrow_up:
e2e-api 42.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Dec 08 '25 22:12 codecov[bot]

@coderabbitai review

aleksandernsilva avatar Dec 16 '25 19:12 aleksandernsilva

✅ Actions performed

Review triggered.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

coderabbitai[bot] avatar Dec 16 '25 19:12 coderabbitai[bot]

lets wait the other changes first to be sure we are ready to jump from alpha to beta

ggazzo avatar Dec 16 '25 21:12 ggazzo

lets wait the other changes first to be sure we are ready to jump from alpha to beta

@ggazzo I'll leave it as draft for now

aleksandernsilva avatar Dec 16 '25 21:12 aleksandernsilva