Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

chore(spelling): fix typos in comments and log messages

Open sid2487 opened this issue 2 months ago • 4 comments

Summary

This PR fixes small spelling mistakes in comments, logs, and user-facing messages.
These changes are non-functional and do not affect code behavior.

Changes

  • occured → occurred
  • recieved → received

Files updated

  • apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts
  • ee/packages/media-calls/src/sip/providers/IncomingSipCall.ts
  • ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts
  • packages/apps-engine/src/definition/messages/IMessageReactionContext.ts
  • packages/apps-engine/src/server/AppManager.ts

Notes

  • No API or functional changes.
  • The typo fix in the mailer API (adresses) was intentionally not included to avoid potential breaking changes.

Summary by CodeRabbit

  • Chores
    • Corrected spelling errors in error messages and documentation comments across multiple components.

✏️ Tip: You can customize this high-level summary in your review settings.

sid2487 avatar Dec 08 '25 06:12 sid2487

⚠️ No Changeset found

Latest commit: 2fa527bf19160ffbb52ad8a634cc82397af7c593

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 08 '25 06:12 changeset-bot[bot]

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Dec 08 '25 06:12 dionisio-bot[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Dec 08 '25 06:12 CLAassistant

Walkthrough

This pull request fixes spelling errors across five files: correcting "occured" to "occurred" in error messages and comments, and "recieved" to "received" in documentation. No functional or behavioral changes are introduced.

Changes

Cohort / File(s) Summary
SAML Error Messages
apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts
Corrected typo in error HTML content: "occured" → "occurred"
SIP Call Error & Log Messages
ee/packages/media-calls/src/sip/providers/IncomingSipCall.ts, ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts
Fixed typos in error log messages: "occured" → "occurred"
App Manager & Engine Definitions
packages/apps-engine/src/server/AppManager.ts, packages/apps-engine/src/definition/messages/IMessageReactionContext.ts
Corrected typos in comment and JSDoc: "occured" → "occurred", "recieved" → "received"

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

This change consists of straightforward, repetitive spelling corrections with no logic modifications, control flow changes, or functional impact.

Suggested labels

stat: ready to merge, stat: QA assured

Suggested reviewers

  • KevLehman
  • lucas-a-pelegrino
  • d-gubert

Poem

🐰 A typo here, a typo there, With "occured" floating in the air, We hop and fix with spelling care, Now "occurred" is spelled just right—fair! ✨

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title 'chore(spelling): fix typos in comments and log messages' accurately summarizes the main change in the PR—correcting spelling mistakes across multiple files.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • [ ] 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • [ ] Create PR with unit tests
  • [ ] Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between d0be8ad3c84ac85a47ff2fe522116c8bc2d0f716 and 2fa527bf19160ffbb52ad8a634cc82397af7c593.

📒 Files selected for processing (5)
  • apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts (1 hunks)
  • ee/packages/media-calls/src/sip/providers/IncomingSipCall.ts (1 hunks)
  • ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts (1 hunks)
  • packages/apps-engine/src/definition/messages/IMessageReactionContext.ts (1 hunks)
  • packages/apps-engine/src/server/AppManager.ts (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
**/*.{ts,tsx,js}

📄 CodeRabbit inference engine (.cursor/rules/playwright.mdc)

**/*.{ts,tsx,js}: Write concise, technical TypeScript/JavaScript with accurate typing in Playwright tests Avoid code comments in the implementation

Files:

  • packages/apps-engine/src/server/AppManager.ts
  • apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts
  • ee/packages/media-calls/src/sip/providers/IncomingSipCall.ts
  • packages/apps-engine/src/definition/messages/IMessageReactionContext.ts
  • ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts
🧠 Learnings (3)
📓 Common learnings
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 37547
File: packages/i18n/src/locales/en.i18n.json:634-634
Timestamp: 2025-11-19T12:32:29.696Z
Learning: Repo: RocketChat/Rocket.Chat
Context: i18n workflow
Learning: In this repository, new translation keys should be added to packages/i18n/src/locales/en.i18n.json only; other locale files are populated via the external translation pipeline and/or fall back to English. Do not request adding the same key to all locale files in future reviews.
📚 Learning: 2025-10-06T20:32:23.658Z
Learnt from: d-gubert
Repo: RocketChat/Rocket.Chat PR: 37152
File: packages/apps-engine/tests/test-data/utilities.ts:557-573
Timestamp: 2025-10-06T20:32:23.658Z
Learning: In packages/apps-engine/tests/test-data/utilities.ts, the field name `isSubscripbedViaBundle` in the `IMarketplaceSubscriptionInfo` type should not be flagged as a typo, as it may match the upstream API's field name.

Applied to files:

  • packages/apps-engine/src/server/AppManager.ts
📚 Learning: 2025-11-19T18:20:37.116Z
Learnt from: gabriellsh
Repo: RocketChat/Rocket.Chat PR: 37419
File: apps/meteor/server/services/media-call/service.ts:141-141
Timestamp: 2025-11-19T18:20:37.116Z
Learning: In apps/meteor/server/services/media-call/service.ts, the sendHistoryMessage method should use call.caller.id or call.createdBy?.id as the message author, not call.transferredBy?.id. Even for transferred calls, the message should appear in the DM between the two users who are calling each other, not sent by the person who transferred the call.

Applied to files:

  • ee/packages/media-calls/src/sip/providers/IncomingSipCall.ts
  • ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts
🧬 Code graph analysis (2)
ee/packages/media-calls/src/sip/providers/IncomingSipCall.ts (1)
ee/packages/media-calls/src/logger.ts (1)
  • logger (3-3)
ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts (1)
ee/packages/media-calls/src/logger.ts (1)
  • logger (3-3)
🔇 Additional comments (5)
apps/meteor/app/meteor-accounts-saml/server/lib/SAML.ts (1)

28-28: LGTM! User-facing typo corrected.

The spelling correction improves the error message quality.

packages/apps-engine/src/server/AppManager.ts (1)

305-305: LGTM! Comment typo corrected.

The spelling correction improves code documentation.

packages/apps-engine/src/definition/messages/IMessageReactionContext.ts (1)

18-18: LGTM! JSDoc typo corrected.

The spelling correction improves the interface documentation.

ee/packages/media-calls/src/sip/providers/IncomingSipCall.ts (1)

176-176: LGTM! Log message typo corrected.

The spelling correction improves error logging quality.

ee/packages/media-calls/src/sip/providers/OutgoingSipCall.ts (1)

228-228: LGTM! Log message typo corrected.

The spelling correction improves error logging quality and maintains consistency with the similar fix in IncomingSipCall.ts.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

coderabbitai[bot] avatar Dec 08 '25 06:12 coderabbitai[bot]