Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

feat: Add "Jump to Message" option for files

Open abirc8010 opened this issue 1 year ago • 3 comments

Proposed changes (including videos or screenshots)

Screencast from 2024-12-15 12-27-57.webm

Issue(s)

RocketChat/feature-requests#915

Steps to test or reproduce

• Go to the All files option. • Choose a file and click on its kebab menu. • Select Jump to message.

abirc8010 avatar Dec 15 '24 07:12 abirc8010

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Dec 15 '24 07:12 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: ee1d34530b31ef6e61e8aa81485934782a5b3ebd

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Dec 15 '24 07:12 changeset-bot[bot]

Currently, the feature works for messages sent after these changes are implemented, as I am adding a messageId attribute to the Uploadsmodel. For files sent before these changes, which don’t have a messageId, the functionality can be achieved by searching for the file by its ID in threads and normal messages. However, I am uncertain about the performance impact of this approach.

abirc8010 avatar Dec 15 '24 07:12 abirc8010