Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

chore: call unsub on useNotifyUser

Open sampaiodiego opened this issue 1 year ago • 4 comments

Proposed changes (including videos or screenshots)

Every time the client loses connection causing the websocket to reconnect and log in again, it was causing the registering multiple callbacks for new notifications.. after a few reconnections there was a lot of callbacks being called and that was causing KonchatNotification.showDesktop to also be called multiple times, causing probably notifications to being show.

Issue(s)

introduced by https://github.com/RocketChat/Rocket.Chat/pull/33981 CORE-859

Steps to test or reproduce

Further comments

sampaiodiego avatar Dec 13 '24 20:12 sampaiodiego

Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Dec 13 '24 20:12 dionisio-bot[bot]

🦋 Changeset detected

Latest commit: 8169270a125770e505bc49b80bbbb30cb9b9d64c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/ui-voip Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Dec 13 '24 20:12 changeset-bot[bot]

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-34174/ on branch gh-pages at 2024-12-16 12:46 UTC

github-actions[bot] avatar Dec 13 '24 20:12 github-actions[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.79%. Comparing base (47f24c2) to head (8169270). Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #34174   +/-   ##
========================================
  Coverage    75.79%   75.79%           
========================================
  Files          511      511           
  Lines        22132    22132           
  Branches      5394     5394           
========================================
  Hits         16775    16775           
  Misses        4709     4709           
  Partials       648      648           
Flag Coverage Δ
unit 75.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Dec 13 '24 20:12 codecov[bot]

/patch

scuciatto avatar Dec 18 '24 18:12 scuciatto

Pull request #34219 added to Project: "Patch 7.1.1"

dionisio-bot[bot] avatar Dec 18 '24 18:12 dionisio-bot[bot]