chore: prune the token whenever we receieve a 403
Proposed changes (including videos or screenshots)
Whenever we try to send a push notification to a stale token, we get the SENDER_ID_MISSMATCH, and we should prune it from our database so we don't keep trying to send to those tokens. This happens when the user has to regenerate their credentials, which had to happen in order to migrate the legacy push notification provider to FCM. Here the approach is similar to: https://github.com/thingsboard/thingsboard/pull/10679 Related issue on that codebase: https://github.com/thingsboard/thingsboard/issues/10602#issuecomment-2085452463
Issue(s)
Steps to test or reproduce
Further comments
Looks like this PR is not ready to merge, because of the following issues:
- This PR is targeting the wrong base branch. It should target 7.4.0, but it targets 7.3.0
Please fix the issues and try again
If you have any trouble, please check the PR guidelines
🦋 Changeset detected
Latest commit: f0edc99b5daa3a5e996b5983b374ff0533b8db05
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 35 packages
| Name | Type |
|---|---|
| @rocket.chat/meteor | Minor |
| @rocket.chat/core-typings | Minor |
| @rocket.chat/rest-typings | Minor |
| @rocket.chat/uikit-playground | Patch |
| @rocket.chat/api-client | Patch |
| @rocket.chat/apps | Patch |
| @rocket.chat/core-services | Patch |
| @rocket.chat/cron | Patch |
| @rocket.chat/ddp-client | Patch |
| @rocket.chat/freeswitch | Patch |
| @rocket.chat/fuselage-ui-kit | Major |
| @rocket.chat/gazzodown | Major |
| @rocket.chat/livechat | Patch |
| @rocket.chat/model-typings | Patch |
| @rocket.chat/ui-contexts | Major |
| @rocket.chat/account-service | Patch |
| @rocket.chat/authorization-service | Patch |
| @rocket.chat/ddp-streamer | Patch |
| @rocket.chat/omnichannel-transcript | Patch |
| @rocket.chat/presence-service | Patch |
| @rocket.chat/queue-worker | Patch |
| @rocket.chat/stream-hub-service | Patch |
| @rocket.chat/license | Patch |
| @rocket.chat/omnichannel-services | Patch |
| @rocket.chat/pdf-worker | Patch |
| @rocket.chat/presence | Patch |
| rocketchat-services | Patch |
| @rocket.chat/models | Patch |
| @rocket.chat/network-broker | Patch |
| @rocket.chat/ui-avatar | Major |
| @rocket.chat/ui-client | Major |
| @rocket.chat/ui-video-conf | Major |
| @rocket.chat/ui-voip | Major |
| @rocket.chat/web-ui-registration | Major |
| @rocket.chat/instance-status | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 75.00%. Comparing base (
4f1021a) to head (f0edc99). Report is 3 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #33885 +/- ##
============================================
+ Coverage 59.17% 75.00% +15.82%
============================================
Files 2822 517 -2305
Lines 68069 22757 -45312
Branches 15136 5523 -9613
============================================
- Hits 40283 17069 -23214
+ Misses 24956 5025 -19931
+ Partials 2830 663 -2167
| Flag | Coverage Δ | |
|---|---|---|
| e2e | ? |
|
| e2e-api | ? |
|
| unit | 75.00% <ø> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
PR Preview Action v1.6.0 :---: |
:rocket: View preview athttps://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33885/
|