Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

feat: move `Enhanced navigation` out of feature preview

Open juliajforesti opened this issue 1 year ago • 4 comments

Proposed changes (including videos or screenshots)

Move Enhanced navigation away from feature preview and make it official SIDE-210

  • delete duplicated Header SIDE-208
  • delete duplicated NavBar
  • delete duplicated sidebar
  • remove newNavigation from feature preview list
  • remove enableQuery from sidepanelNavigation feature
  • adjust tests SIDE-181

Issue(s)

Steps to test or reproduce

Further comments

juliajforesti avatar Oct 10 '24 19:10 juliajforesti

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Oct 10 '24 19:10 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: e6c26cdeedd36915d72216048d36887ea364569c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Oct 10 '24 19:10 changeset-bot[bot]

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33529/ on branch gh-pages at 2024-12-23 14:54 UTC

github-actions[bot] avatar Oct 10 '24 21:10 github-actions[bot]

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 59.24%. Comparing base (c84543f) to head (e6c26cd). :warning: Report is 1908 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33529      +/-   ##
===========================================
- Coverage    59.28%   59.24%   -0.05%     
===========================================
  Files         2820     2807      -13     
  Lines        67932    67763     -169     
  Branches     15102    15054      -48     
===========================================
- Hits         40275    40147     -128     
+ Misses       24831    24804      -27     
+ Partials      2826     2812      -14     
Flag Coverage Δ
unit 66.58% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar Oct 10 '24 22:10 codecov[bot]

done here #37285

juliajforesti avatar Dec 22 '25 13:12 juliajforesti