i18n: missing pt-BR translation for non-member user mentions
Proposed changes (including videos or screenshots)
Fix missing translations for mention notifications in pt-BR locale when a user is mentioned but not part of the current channel.
Issue(s)
Steps to test or reproduce
Further comments
⚠️ No Changeset found
Latest commit: f086e08a369ca093bd25486e0a9761b490f0e259
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Looks like this PR is not ready to merge, because of the following issues:
- This PR is missing the required milestone or project
Please fix the issues and try again
If you have any trouble, please check the PR guidelines
PR Preview Action v1.4.8
:---:
:rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33413/
on branch gh-pages at 2024-10-17 23:20 UTC
Codecov Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 58.52%. Comparing base (b338807) to head (f086e08).
:warning: Report is 2095 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #33413 +/- ##
============================================
- Coverage 74.85% 58.52% -16.34%
============================================
Files 470 2777 +2307
Lines 20743 66566 +45823
Branches 5294 15037 +9743
============================================
+ Hits 15528 38957 +23429
- Misses 4595 24785 +20190
- Partials 620 2824 +2204
| Flag | Coverage Δ | |
|---|---|---|
| unit | 67.16% <ø> (-7.70%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Did anyone test this in older versions to make sure?
Yes, on version 6.12.1, it shows the text in English (fallback for missing translation).
The title of the Jira ticket I created may have caused some confusion, I apologize for that. The issue is that the fallback translation is not working properly - if you try the same behavior using languages such as "Belarusian" the problem will still happen. It should use the default language (english) when there's no translation available.
@gabriellsh Your points were addressed here #33440
Since the translations itself don't categorize as regression, I am changing this PR's prefix to i18n and milestone to 6.14.