fix: login service configuration notifier event
As per OPI-39, we've identified scenarios where a "no broker set to broadcast" message appears, particularly in the "watch.loginServiceConfiguration" event. After reviewing the root cause, we've determined that it's unnecessary to stream changes in real-time through the socket when the server checks for updates to OAuth provider configurations.
Looks like this PR is not ready to merge, because of the following issues:
- This PR is missing the 'stat: QA assured' label
- This PR is missing the required milestone or project
Please fix the issues and try again
If you have any trouble, please check the PR guidelines
⚠️ No Changeset found
Latest commit: 1638336da6d2e625c730722c2539683a11f19251
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
PR Preview Action v1.4.8
:---:
:rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-33410/
on branch gh-pages at 2024-10-09 23:01 UTC
Codecov Report
:x: Patch coverage is 16.66667% with 5 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 58.55%. Comparing base (bcacbb1) to head (1638336).
:warning: Report is 2184 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #33410 +/- ##
===========================================
- Coverage 58.58% 58.55% -0.03%
===========================================
Files 2737 2737
Lines 65757 65781 +24
Branches 14825 14831 +6
===========================================
- Hits 38521 38520 -1
- Misses 24457 24482 +25
Partials 2779 2779
| Flag | Coverage Δ | |
|---|---|---|
| unit | 67.12% <16.66%> (+3.28%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.
:rocket: New features to boost your workflow:
- :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.