fix: Multi-step modals closing unexpectedly

[dougfabris]

Introduced here: #32482

Proposed changes (including videos or screenshots)

With the introduction of the onClose call in the useEffect cleanup function in GenericModal, multi-step modals using GenericModal started to close unexpectedly. This PR aims to remove the usage of the GenericModal in favor of GenericModalSkeleton to solve this issue and keep the loading consistency.

Issue(s)

Steps to test or reproduce

Further comments

CORE-660

[dionisio-bot[bot]]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is targeting the wrong base branch. It should target 6.13.0, but it targets 6.12.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot[bot]]

🦋 Changeset detected

Latest commit: 320a8ddea00c3482b3e87a6ebc0e7dfcf2b6f039

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages

Name	Type
@rocket.chat/meteor	Patch
@rocket.chat/core-typings	Patch
@rocket.chat/rest-typings	Patch
@rocket.chat/api-client	Patch
@rocket.chat/apps	Patch
@rocket.chat/core-services	Patch
@rocket.chat/cron	Patch
@rocket.chat/ddp-client	Patch
@rocket.chat/fuselage-ui-kit	Patch
@rocket.chat/gazzodown	Patch
@rocket.chat/livechat	Patch
@rocket.chat/model-typings	Patch
@rocket.chat/ui-contexts	Patch
@rocket.chat/account-service	Patch
@rocket.chat/authorization-service	Patch
@rocket.chat/ddp-streamer	Patch
@rocket.chat/omnichannel-transcript	Patch
@rocket.chat/presence-service	Patch
@rocket.chat/queue-worker	Patch
@rocket.chat/stream-hub-service	Patch
@rocket.chat/license	Patch
@rocket.chat/omnichannel-services	Patch
@rocket.chat/pdf-worker	Patch
@rocket.chat/presence	Patch
rocketchat-services	Patch
@rocket.chat/uikit-playground	Patch
@rocket.chat/models	Patch
@rocket.chat/ui-avatar	Patch
@rocket.chat/ui-client	Patch
@rocket.chat/ui-video-conf	Patch
@rocket.chat/web-ui-registration	Patch
@rocket.chat/instance-status	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[codecov[bot]]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.33%. Comparing base (9ef09d8) to head (320a8dd). Report is 1 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop   #33158   +/-   ##
========================================
  Coverage    59.33%   59.33%           
========================================
  Files         2547     2546    -1     
  Lines        63258    63247   -11     
  Branches     14221    14220    -1     
========================================
- Hits         37531    37529    -2     
+ Misses       23025    23016    -9     
  Partials      2702     2702           

Flag	Coverage Δ
unit	75.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[scuciatto]

/patch

[dionisio-bot[bot]]

    Sorry, I couldn't do that backport because of conflicts. Could you please solve them?
    
    you can do so by running the following commands:

git fetch
git checkout backport-6.11.2-33158
git cherry-pick 5cbbb4585146fe28474fe89789172218abd266f8
// solve the conflict
git push

after that just run /patch again

[dougfabris]

/patch

[dionisio-bot[bot]]

Pull request #33178 added to Project: "Patch 6.11.2"