Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

chore: remove notifyListener call that was causing startup issues

Open ricardogarim opened this issue 1 year ago • 3 comments

This PR addresses a specific issue where the no broker set to broadcast: watch.settings error would occur for certain users, particularly during the dry run initialization of the development environment.

It's important to note that while this fix resolves this particular error, similar issues could arise in other parts of the code. These will need to be addressed in future updates as they are identified.

ricardogarim avatar Aug 26 '24 18:08 ricardogarim

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.13.0, but it targets 6.12.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Aug 26 '24 18:08 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: 13fa9d030e9c06e63b9d64f5631e3c026873bfe9

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 26 '24 18:08 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.33%. Comparing base (5cbbb45) to head (13fa9d0). Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #33154      +/-   ##
===========================================
- Coverage    59.33%   59.33%   -0.01%     
===========================================
  Files         2546     2546              
  Lines        63247    63245       -2     
  Branches     14220    14220              
===========================================
- Hits         37529    37527       -2     
  Misses       23016    23016              
  Partials      2702     2702              
Flag Coverage Δ
unit 75.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 26 '24 18:08 codecov[bot]