Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

feat: VoIP freeswitch UI start call actions

Open aleksandernsilva opened this issue 1 year ago • 3 comments

❗❗DO NOT MERGE BEFORE #33007 ❗❗

Proposed changes (including videos or screenshots)

This PR adds triggers for enabling/disable voice calling, start 1:1 a voice calls and start calls from the dialer.

Enabled/disable voice calling

Screenshot 2024-08-15 at 14 10 45

Start call menu in room toolbox (direct messages)

Screenshot 2024-08-15 at 14 01 34

Start call from user card

Screenshot 2024-08-15 at 14 02 36

Start voice call from profile contextual bar

Screenshot 2024-08-15 at 14 03 06

Start voice call from members contextual bar

Screenshot 2024-08-15 at 14 08 38

Open dial pad (NavBarV2)

Screenshot 2024-08-22 at 11 35 17

Issue(s)

VOIP-74 VOIP-50 VOIP-84

Steps to test or reproduce

  • Go to workspace settings

  • Enable VoIP for Team Collab

  • Back to home

  • Click profile picture

  • Enable voice calling

  • Go to direct message

  • Start call in the room toolbox

  • For the dial pad button it's also necessary to enabled "Enhanced navigation experience" in Feature Preview.

Further comments

ℹ️ Commits might help more easily review/navigate each of the mentioned actions.

aleksandernsilva avatar Aug 07 '24 21:08 aleksandernsilva

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is targeting the wrong base branch. It should target 6.14.0, but it targets 6.13.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Aug 07 '24 21:08 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: a795c52b7bdd5510e90a209c916851cc3d82794f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 07 '24 21:08 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (feat/freeswitch-6-12@c81fc2f). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             feat/freeswitch-6-12   #33008   +/-   ##
=======================================================
  Coverage                        ?   59.46%           
=======================================================
  Files                           ?     2596           
  Lines                           ?    63284           
  Branches                        ?    14198           
=======================================================
  Hits                            ?    37629           
  Misses                          ?    22962           
  Partials                        ?     2693           
Flag Coverage Δ
unit 75.49% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 22 '24 00:08 codecov[bot]

PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-09-26 21:38 UTC

github-actions[bot] avatar Sep 16 '24 18:09 github-actions[bot]