Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

feat: VoIP freeswitch UI admin

Open aleksandernsilva opened this issue 1 year ago • 3 comments

❗❗DO NOT MERGE BEFORE #33093 ❗❗

Proposed changes (including videos or screenshots)

This PR adds all necessary logic for assignment and unasignment of VoIP extensions in the admin users page. Configuring this information will allow users to make and receive call in team collab.

The changes can be broken down in three parts:

Assign/Remove extension button added to the workspace user list

Screenshot 2024-08-15 at 11 10 07

Assign extension modal

Screenshot 2024-08-15 at 11 10 30

Remove extension modal

Screenshot 2024-08-15 at 11 10 47

Issue(s)

VOIP-71

Steps to test or reproduce

  • Run your workspace
  • Enable "VoIP for Team Collaboration" in the workspace settings
  • Go to /admin/users

Further comments

Backend can be found in this PR: #32435

aleksandernsilva avatar Aug 07 '24 21:08 aleksandernsilva

⚠️ No Changeset found

Latest commit: fcbf18373624df5d104f2f9cd4da3cd262c331c3

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 07 '24 21:08 changeset-bot[bot]

Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Aug 07 '24 21:08 dionisio-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (feat/freeswitch-6-12@ae54a18). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                   Coverage Diff                   @@
##             feat/freeswitch-6-12   #33004   +/-   ##
=======================================================
  Coverage                        ?   76.85%           
=======================================================
  Files                           ?      380           
  Lines                           ?    19059           
  Branches                        ?     4910           
=======================================================
  Hits                            ?    14647           
  Misses                          ?     4185           
  Partials                        ?      227           
Flag Coverage Δ
unit 76.85% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 20 '24 17:08 codecov[bot]

PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-09-23 13:46 UTC

github-actions[bot] avatar Sep 13 '24 00:09 github-actions[bot]