Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

fix(fuselage-ui-kit): `MultiStaticSelectElement` not working as expected using `dispatchActionConfig: ['on_item_selected']`

Open tiagoevanp opened this issue 1 year ago • 3 comments

Proposed changes (including videos or screenshots)

Change actionFunction in useUiKitState to update the state value correctly when using MultiStaticSelectElement with a config dispatchActionConfig from UiKit

Issue(s)

Steps to test or reproduce

Further comments

SUP-629

tiagoevanp avatar Aug 07 '24 09:08 tiagoevanp

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is targeting the wrong base branch. It should target 6.13.0, but it targets 6.12.0

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Aug 07 '24 09:08 dionisio-bot[bot]

🦋 Changeset detected

Latest commit: d49b8fa8925d3088843d25fa0532281a2d22776d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 32 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Aug 07 '24 09:08 changeset-bot[bot]

Codecov Report

Attention: Patch coverage is 28.57143% with 5 lines in your changes missing coverage. Please review.

Project coverage is 59.32%. Comparing base (3ba1854) to head (d49b8fa). Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #32999      +/-   ##
===========================================
+ Coverage    59.31%   59.32%   +0.01%     
===========================================
  Files         2547     2547              
  Lines        63343    63346       +3     
  Branches     14252    14254       +2     
===========================================
+ Hits         37570    37581      +11     
+ Misses       23070    23062       -8     
  Partials      2703     2703              
Flag Coverage Δ
unit 75.23% <28.57%> (+0.04%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Aug 07 '24 10:08 codecov[bot]