chore: Convert `saveUser` file to TS
Proposed changes (including videos or screenshots)
- Convert
saveUserfile to TS, also removing unused parameters handling; - Fix
IUserSettingstype to have an optionalprofile, as set through the API.
Issue(s)
Steps to test or reproduce
Further comments
Looks like this PR is not ready to merge, because of the following issues:
- This PR is targeting the wrong base branch. It should target 7.3.0, but it targets 7.2.0
Please fix the issues and try again
If you have any trouble, please check the PR guidelines
⚠️ No Changeset found
Latest commit: 3245d246bbe396c867373c162c2a94ff242e68f4
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Codecov Report
Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.
Project coverage is 59.19%. Comparing base (
5506c40) to head (3245d24). Report is 1 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #32993 +/- ##
========================================
Coverage 59.19% 59.19%
========================================
Files 2821 2821
Lines 67633 67633
Branches 15048 15048
========================================
Hits 40033 40033
Misses 24784 24784
Partials 2816 2816
| Flag | Coverage Δ | |
|---|---|---|
| unit | 74.99% <75.00%> (ø) |
Flags with carried forward coverage won't be shown. Click here to find out more.
@matheusbsilva137 the task linked doesn't seem to relate that much with what you're doing here. Maybe this needs its own task?
PR Preview Action v1.4.8
:---:
:rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-32993/
on branch gh-pages at 2025-01-02 19:46 UTC
We converted saveUser file to TS in another PR (#33774). However, I decided to keep my PR so that we don't lose any of the typing refinements suggested here that weren't applied to the conversion PR.
Instead of converting the file to TS, this PR now aims to improve type-checking in this file, while using our new updater :)
Feel free to review it again, everyone! (Please check the PR description for details on what I'm changing in this PR)