Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

fix: Correct email validation and error message display in MailExportForm

Open smritidoneria opened this issue 1 year ago • 5 comments

Proposed changes (including videos or screenshots)

The validateEmail function has been updated to correctly validate email addresses according to the RFC standard. It now correctly identifies email addresses without a top-level domain (e.g., "user@domain") as invalid.

The error message for the messagesCount field is now only displayed when the user doesn't select any message https://github.com/user-attachments/assets/5c0fa949-ff12-4b41-9718-c5b226d7c82c

Issue(s)

Closes #32974

Steps to test or reproduce

1.Navigate to the MailExportForm component. 2.Test the email validation by entering an email address without a top-level domain and attempting to submit the form. The form should correctly identify the email as invalid. 3.Select a message. The error message for the messagesCount field should not be displayed when you have selected the messages.

Further comments

smritidoneria avatar Aug 03 '24 12:08 smritidoneria

⚠️ No Changeset found

Latest commit: 994ab4192d6d29fe23e3ba38d4476ac8f86f0f02

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Aug 03 '24 12:08 changeset-bot[bot]

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Aug 03 '24 12:08 CLAassistant

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Aug 05 '24 11:08 dionisio-bot[bot]

FYI - Community Liaison (reetp) shared this with internal teams and we'll be working on it soon. Thanks for the issue and PR

casalsgh avatar Aug 05 '24 11:08 casalsgh

Can I check what is the update on the pr?

smritidoneria avatar Sep 14 '24 04:09 smritidoneria

Hi there, thanks for the contribution! 🚀 💯

Closing this PR because it's stale now and it doesn't fix a proper issue.


Questions? Help needed? Feature Requests?

  • Join our Open Server in the #support channel and feel free to raise a question
  • Join our Community Forum and search/create a post there

dougfabris avatar Nov 03 '25 15:11 dougfabris