Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

fix: AAC audio type does not play on web

Open matheusbsilva137 opened this issue 1 year ago • 3 comments

Proposed changes (including videos or screenshots)

  • Define aac files MIME type as audio/aac instead of audio/x-aac (which is not supported by our audio player);

Issue(s)

Introduced by #32471

Steps to test or reproduce

Further comments

NATIVE-592

matheusbsilva137 avatar Jul 11 '24 16:07 matheusbsilva137

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Jul 11 '24 16:07 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: a90069fbf5f123f871cdfca3b606e49c89c9ccbf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jul 11 '24 16:07 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 56.66%. Comparing base (f2cb691) to head (a90069f).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #32764   +/-   ##
========================================
  Coverage    56.65%   56.66%           
========================================
  Files         2504     2504           
  Lines        55524    55525    +1     
  Branches     11442    11442           
========================================
+ Hits         31456    31461    +5     
+ Misses       21380    21376    -4     
  Partials      2688     2688           
Flag Coverage Δ
e2e 56.47% <100.00%> (+0.02%) :arrow_up:
unit 72.21% <100.00%> (-0.01%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jul 11 '24 16:07 codecov[bot]

Closing in favor of #32763 (the changes suggested in this PR have been incorporated there)

matheusbsilva137 avatar Jul 12 '24 19:07 matheusbsilva137