fix(UiKit): Modal validation not working
Proposed changes (including videos or screenshots)
Bring back modal validations response to inputs:
Issue(s)
Steps to test or reproduce
Further comments
Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines
🦋 Changeset detected
Latest commit: f454ae9de42dc5b0c650fdfa5a695efa2736c7ca
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 32 packages
| Name | Type |
|---|---|
| @rocket.chat/meteor | Patch |
| @rocket.chat/fuselage-ui-kit | Patch |
| @rocket.chat/uikit-playground | Patch |
| @rocket.chat/core-typings | Patch |
| @rocket.chat/rest-typings | Patch |
| @rocket.chat/apps | Patch |
| @rocket.chat/core-services | Patch |
| @rocket.chat/cron | Patch |
| @rocket.chat/gazzodown | Patch |
| @rocket.chat/livechat | Patch |
| @rocket.chat/model-typings | Patch |
| @rocket.chat/ui-contexts | Patch |
| @rocket.chat/account-service | Patch |
| @rocket.chat/authorization-service | Patch |
| @rocket.chat/ddp-streamer | Patch |
| @rocket.chat/omnichannel-transcript | Patch |
| @rocket.chat/presence-service | Patch |
| @rocket.chat/queue-worker | Patch |
| @rocket.chat/stream-hub-service | Patch |
| @rocket.chat/api-client | Patch |
| @rocket.chat/license | Patch |
| @rocket.chat/omnichannel-services | Patch |
| @rocket.chat/pdf-worker | Patch |
| @rocket.chat/presence | Patch |
| rocketchat-services | Patch |
| @rocket.chat/ddp-client | Patch |
| @rocket.chat/models | Patch |
| @rocket.chat/ui-avatar | Patch |
| @rocket.chat/ui-client | Patch |
| @rocket.chat/ui-video-conf | Patch |
| @rocket.chat/web-ui-registration | Patch |
| @rocket.chat/instance-status | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 55.55%. Comparing base (
35985d7) to head (f454ae9).
Additional details and impacted files
@@ Coverage Diff @@
## develop #32679 +/- ##
===========================================
- Coverage 55.58% 55.55% -0.03%
===========================================
Files 2635 2635
Lines 57289 57289
Branches 11864 11864
===========================================
- Hits 31843 31828 -15
- Misses 22750 22764 +14
- Partials 2696 2697 +1
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 54.27% <ø> (-0.06%) |
:arrow_down: |
| unit | 72.25% <ø> (+0.01%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.