Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

chore!: Remove `meteor/check` from `custom-user-status` endpoints

Open matheusbsilva137 opened this issue 1 year ago • 4 comments

Proposed changes (including videos or screenshots)

  • Remove meteor/check from custom-user-status endpoints by using the validateParams property.

Issue(s)

CORE-318

Steps to test or reproduce

Further comments

The intention for this PR is to improve code readability and make invalid params errors more standardized. No side effects are expected. We're considering this a breaking change since invalid params errors are being changed to follow the same standard when possible.

matheusbsilva137 avatar Jun 03 '24 20:06 matheusbsilva137

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Jun 03 '24 20:06 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: d2ef9e6587ac60040ae672504ba2823d353358c6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Jun 03 '24 20:06 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 75.70%. Comparing base (b97c106) to head (d2ef9e6). Report is 527 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff              @@
##           develop   #32549       +/-   ##
============================================
+ Coverage    58.59%   75.70%   +17.10%     
============================================
  Files         2739      432     -2307     
  Lines        65696    19919    -45777     
  Branches     14826     5084     -9742     
============================================
- Hits         38496    15079    -23417     
+ Misses       24420     4269    -20151     
+ Partials      2780      571     -2209     
Flag Coverage Δ
e2e ?
e2e-api ?
unit 75.70% <ø> (+0.03%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jun 03 '24 20:06 codecov[bot]

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-32549/ on branch gh-pages at 2024-10-11 21:52 UTC

github-actions[bot] avatar Oct 11 '24 21:10 github-actions[bot]