Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

chore!: Remove `meteor/check` from `cloud` endpoints

Open matheusbsilva137 opened this issue 1 year ago • 3 comments

Proposed changes (including videos or screenshots)

  • Remove meteor/check from cloud endpoints by using the validateParams property.

Issue(s)

CORE-317

Steps to test or reproduce

Further comments

The intention for this PR is to improve code readability and make invalid params errors more standardized. No side effects are expected. We're considering this a breaking change since invalid params errors are being changed to follow the same standard when possible.

matheusbsilva137 avatar May 31 '24 18:05 matheusbsilva137

Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar May 31 '24 18:05 dionisio-bot[bot]

⚠️ No Changeset found

Latest commit: 3d87d8e71fb2e7bc28287a91eccd6d002b032a17

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar May 31 '24 18:05 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.39%. Comparing base (8c447cf) to head (3d87d8e). Report is 3 commits behind head on release-7.0.0.

Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff               @@
##           release-7.0.0   #32533   +/-   ##
==============================================
  Coverage          59.39%   59.39%           
==============================================
  Files               2541     2541           
  Lines              63175    63175           
  Branches           14220    14220           
==============================================
  Hits               37525    37525           
  Misses             22935    22935           
  Partials            2715     2715           
Flag Coverage Δ
unit 76.02% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar May 31 '24 18:05 codecov[bot]