feat: E2EE messages mentions
Proposed changes (including videos or screenshots)
In Rocket.Chat, while end-to-end encryption secures user messages in private rooms, it currently does not support the functionality to mention specific users within these encrypted conversations. This limitation reduces the usability and interactivity of the chat, as users cannot directly alert or reference other participants. Enabling mentions in encrypted rooms will enhance communication efficiency and user engagement without compromising the security of the encryption.
Acceptance criteria (DoD)
- Functionality Implementation: Users should be able to mention other users, teams, and @all and @here in end-to-end encrypted rooms using the '@' symbol followed by the username, exactly the same functionality in non-encrypted rooms.
- Autocomplete Feature: As a user types a mention, an autocomplete feature should suggest possible usernames based on the current participants in the room, exactly the same functionality in non-encrypted rooms.
- Notification Handling: Users who are mentioned should receive notifications if they have notifications enabled, exactly the same functionality in non-encrypted rooms.
- Security Compliance: The implementation of mentions must not compromise the encryption integrity of the message, but it’s not required the mention to be end-to-end encrypted.
- Performance Impact: Ensure that the introduction of mentions does not significantly impact the performance and responsiveness of the chat system.
- User Experience: The user interface for mentions in encrypted rooms should be seamless and intuitive, without requiring additional steps or complications for the user.
- Accessibility and Compatibility: Ensure that mentions are accessible and function consistently across all supported devices and platforms.
- Create a new setting
Issue(s)
Steps to test or reproduce
Further comments
https://rocketchat.atlassian.net/browse/E2EE2-8
Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines
🦋 Changeset detected
Latest commit: 1eeff2db03962d2d09c49d96b22fb785484aad5c
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 34 packages
| Name | Type |
|---|---|
| @rocket.chat/meteor | Minor |
| @rocket.chat/core-typings | Minor |
| @rocket.chat/i18n | Patch |
| @rocket.chat/api-client | Patch |
| @rocket.chat/apps | Patch |
| @rocket.chat/core-services | Patch |
| @rocket.chat/cron | Patch |
| @rocket.chat/ddp-client | Patch |
| @rocket.chat/fuselage-ui-kit | Major |
| @rocket.chat/gazzodown | Major |
| @rocket.chat/livechat | Patch |
| @rocket.chat/model-typings | Patch |
| @rocket.chat/rest-typings | Minor |
| @rocket.chat/ui-contexts | Major |
| @rocket.chat/account-service | Patch |
| @rocket.chat/authorization-service | Patch |
| @rocket.chat/ddp-streamer | Patch |
| @rocket.chat/omnichannel-transcript | Patch |
| @rocket.chat/presence-service | Patch |
| @rocket.chat/queue-worker | Patch |
| @rocket.chat/stream-hub-service | Patch |
| @rocket.chat/license | Patch |
| @rocket.chat/omnichannel-services | Patch |
| @rocket.chat/pdf-worker | Patch |
| @rocket.chat/presence | Patch |
| rocketchat-services | Patch |
| @rocket.chat/mock-providers | Patch |
| @rocket.chat/web-ui-registration | Major |
| @rocket.chat/uikit-playground | Patch |
| @rocket.chat/models | Patch |
| @rocket.chat/ui-avatar | Major |
| @rocket.chat/ui-client | Major |
| @rocket.chat/ui-video-conf | Major |
| @rocket.chat/instance-status | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Codecov Report
Attention: Patch coverage is 71.42857% with 2 lines in your changes missing coverage. Please review.
Project coverage is 59.70%. Comparing base (
636d32d) to head (1eeff2d). Report is 14 commits behind head on develop.
Additional details and impacted files
@@ Coverage Diff @@
## develop #32510 +/- ##
=========================================
Coverage 59.70% 59.70%
=========================================
Files 2551 2551
Lines 62792 62908 +116
Branches 14102 14128 +26
=========================================
+ Hits 37492 37562 +70
- Misses 22893 22929 +36
- Partials 2407 2417 +10
| Flag | Coverage Δ | |
|---|---|---|
| unit | 76.90% <71.42%> (-0.01%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
PR Preview Action v1.4.8 :---: Preview removed because the pull request was closed. 2024-09-20 00:15 UTC