fix: Blocked login when dismissed 2FA modal
Proposed changes (including videos or screenshots)
Fix infinite loading button in login page when 2FA dismissed. PR introduces the possibility of a function trigger to Modal dismiss (outside click and escape key).
Before:
After:
Issue(s)
Steps to test or reproduce
Further comments
🦋 Changeset detected
Latest commit: c3e0ca9d26ffd98e4baebe0693b7804226fc27c2
The changes in this PR will be included in the next version bump.
This PR includes changesets to release 33 packages
| Name | Type |
|---|---|
| @rocket.chat/meteor | Patch |
| @rocket.chat/mock-providers | Patch |
| @rocket.chat/ui-contexts | Patch |
| @rocket.chat/web-ui-registration | Patch |
| @rocket.chat/fuselage-ui-kit | Patch |
| @rocket.chat/ui-client | Patch |
| @rocket.chat/gazzodown | Patch |
| @rocket.chat/livechat | Patch |
| @rocket.chat/ui-avatar | Patch |
| @rocket.chat/ui-video-conf | Patch |
| @rocket.chat/uikit-playground | Patch |
| @rocket.chat/ddp-streamer | Patch |
| @rocket.chat/omnichannel-transcript | Patch |
| @rocket.chat/core-typings | Patch |
| @rocket.chat/rest-typings | Patch |
| @rocket.chat/apps | Patch |
| @rocket.chat/core-services | Patch |
| @rocket.chat/cron | Patch |
| @rocket.chat/model-typings | Patch |
| @rocket.chat/account-service | Patch |
| @rocket.chat/authorization-service | Patch |
| @rocket.chat/presence-service | Patch |
| @rocket.chat/queue-worker | Patch |
| @rocket.chat/stream-hub-service | Patch |
| @rocket.chat/api-client | Patch |
| @rocket.chat/license | Patch |
| @rocket.chat/omnichannel-services | Patch |
| @rocket.chat/pdf-worker | Patch |
| @rocket.chat/presence | Patch |
| rocketchat-services | Patch |
| @rocket.chat/ddp-client | Patch |
| @rocket.chat/models | Patch |
| @rocket.chat/instance-status | Patch |
Not sure what this means? Click here to learn what changesets are.
Click here if you're a maintainer who wants to add another changeset to this PR
Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines
Codecov Report
Attention: Patch coverage is 94.87179% with 2 lines in your changes missing coverage. Please review.
Project coverage is 55.58%. Comparing base (
ebc858f) to head (c3e0ca9).
Additional details and impacted files
@@ Coverage Diff @@
## develop #32482 +/- ##
===========================================
- Coverage 55.59% 55.58% -0.02%
===========================================
Files 2634 2634
Lines 57252 57273 +21
Branches 11857 11860 +3
===========================================
+ Hits 31832 31837 +5
- Misses 22729 22750 +21
+ Partials 2691 2686 -5
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 54.30% <87.09%> (-0.06%) |
:arrow_down: |
| unit | 72.33% <94.87%> (+0.22%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.