feat: notify on reactions
Proposed changes (including videos or screenshots)
isssue #32297
This PR notifies the user when someone reacts on the message and also increases the unread count in the sidebar
Issue(s)
Steps to test or reproduce
Further comments
⚠️ No Changeset found
Latest commit: a9a40528588099d2b4bed9c39c7cdae09da3e89d
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Hi @reetp , I'm new to open source contributions and have recently developed a feature based on an issue. I submitted a PR a few days ago. Could you please suggest what my next steps should be to ensure my PR gets merged successfully?
You don't need to ping me.
You have the attention of a dev.
Keep your PR in line with the latest code and hope they choose to merge it.
That will likely be up to the product team.
An "Enable/Disable" preference might be worth looking at too - not everyone wants to be bombarded with notifications!
@VenkataRohan can you make it availabe as a possible setting? We don't want to change the default behavior we have, but also want to permit this to be a possible setup.
Hi @casalsgh , sure I am working on it , I will update here as soon as I implement it
Hi @ggazzo @casalsgh , now in this commit I have removed increase unread count and added an option of selecting notification on reaction
hey @VenkataRohan thanks for all the changes. lets keep the setting so, its not a big deal.
I would like to work on this issue if it is not closed.
Hi @Akshanshkaushal I was waiting for a reply from @casalsgh , @ggazzo , I have already implement the feature and made changes suggested , waiting for the team to review it , and ready to work on any suggestion if required.
Hi @ggazzo @casalsgh , now in this commit I have removed increase unread count and added an option of selecting notification on reaction
Good job. These sorts of things are like Marmite. Some love them, some hate them.
I'd guess it could chew through a lot of push notifications too?
This could drive many people mad, especially in busy channels.
So options to disable it are good.
Looks like this PR is not ready to merge, because of the following issues:
- This PR is missing the 'stat: QA assured' label
- This PR is missing the required milestone or project
Please fix the issues and try again
If you have any trouble, please check the PR guidelines
Hi @Parvezkhan0, @ggazzo , @casalsgh
I have added added fallback mechanism if translation fails as request by @Parvezkhan0 and also some good amount for changes to the code to optimse the translation of "Reacted With" process
also I have added the message to which in the notification as shown below.
the latest commit a9a40528588099d2b4bed9c39c7cdae09da3e89d has all the change. we can also rebase all the previous commit