Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

fix: No preview for links without schema

Open apurb-coder opened this issue 2 years ago • 2 comments

Proposed changes (including videos or screenshots)

Before:

Screenshot 2024-01-30 134824

After:

Screenshot 2024-01-30 134848

Changes I made:

Will generate Preview for links without Protocols or Schema. Also the regular expression ^\w+:\/\/.* used in the condition to match any protocol, not just http, https, or ftp .

Issue(s)

Closes #27235

Steps to test or reproduce

Further comments

apurb-coder avatar Feb 12 '24 17:02 apurb-coder

⚠️ No Changeset found

Latest commit: a38d019ffa619df4775db620c1775ca37e56b904

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 12 '24 17:02 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (cb9c6ba) 54.33% compared to head (a38d019) 54.33%.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31741      +/-   ##
===========================================
- Coverage    54.33%   54.33%   -0.01%     
===========================================
  Files         2276     2276              
  Lines        50124    50123       -1     
  Branches     10220    10220              
===========================================
- Hits         27233    27232       -1     
- Misses       20406    20437      +31     
+ Partials      2485     2454      -31     
Flag Coverage Δ
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Feb 12 '24 17:02 codecov[bot]