Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

feat: Trigger chat-visitor-registered on 'new chat' after closing

Open MartinSchoeler opened this issue 2 years ago • 2 comments

This will allow the after-guest-registration trigger to run when starting a new chat after finishing a chat when the clear guest data when chat ended setting is set to false

REQUIRES https://github.com/RocketChat/Rocket.Chat/pull/31268

SUP-483

MartinSchoeler avatar Feb 09 '24 18:02 MartinSchoeler

🦋 Changeset detected

Latest commit: d3ba2b89701d5ed6a48f03914cbb520c0e47e4e1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@rocket.chat/livechat Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 09 '24 18:02 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.53%. Comparing base (38a2036) to head (d3ba2b8). Report is 1 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31718      +/-   ##
===========================================
+ Coverage    54.46%   54.53%   +0.06%     
===========================================
  Files         2290     2294       +4     
  Lines        50513    50562      +49     
  Branches     10318    10325       +7     
===========================================
+ Hits         27513    27572      +59     
+ Misses       20504    20487      -17     
- Partials      2496     2503       +7     
Flag Coverage Δ
e2e 53.54% <ø> (+0.06%) :arrow_up:
e2e-api 40.15% <ø> (+0.10%) :arrow_up:
unit 75.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Feb 09 '24 18:02 codecov[bot]

as expected both tests are failing before the fix:

✘  60 omnichannel/omnichannel-triggers.spec.ts:229:13 › OC - Livechat New Chat Triggers › OC - Livechat New Chat Triggers - After Registration › expect trigger message after registration (5.0s)
Sending test result to Rocket.Chat: {"name":"expect trigger message after registration","status":"failed","duration":5028,"branch":"refs/pull/31718/merge","draft":false,"run":17995}
✘  61 omnichannel/omnichannel-triggers.spec.ts:248:13 › OC - Livechat New Chat Triggers › OC - Livechat New Chat Triggers - After Registration, clear Local storage › expect trigger message after registration (5.3s)

ggazzo avatar Mar 14 '24 21:03 ggazzo