Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

feat: Improve File Upload modal and endpoint

Open matheusbsilva137 opened this issue 2 years ago • 2 comments

Proposed changes (including videos or screenshots)

  • Accept new altDescription param in the rooms.upload endpoint. This can be used by screen readers to describe images;
  • Improve File Upload modal to have a new Message Box component in it, which allows users to mention other users os rooms easily;
  • Send File Upload text content in the msg field instead of description (this allows mentions to be processed and rendered correctly).

Issue(s)

Steps to test or reproduce

Further comments

CORE-16

matheusbsilva137 avatar Feb 08 '24 17:02 matheusbsilva137

⚠️ No Changeset found

Latest commit: 646318b814cf2abd6c41561e4d21ce608e2f7b81

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

changeset-bot[bot] avatar Feb 08 '24 17:02 changeset-bot[bot]

Codecov Report

Attention: Patch coverage is 10.81081% with 66 lines in your changes are missing coverage. Please review.

Project coverage is 53.23%. Comparing base (9c06e1d) to head (646318b). Report is 231 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31698      +/-   ##
===========================================
- Coverage    54.56%   53.23%   -1.34%     
===========================================
  Files         2273     2266       -7     
  Lines        50110    49811     -299     
  Branches     10223    10151      -72     
===========================================
- Hits         27344    26515     -829     
- Misses       20294    20879     +585     
+ Partials      2472     2417      -55     
Flag Coverage Δ
e2e 51.05% <10.81%> (-2.46%) :arrow_down:
e2e-api 39.91% <ø> (-0.04%) :arrow_down:
unit 76.47% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Feb 08 '24 18:02 codecov[bot]

Looks like this PR is not ready to merge, because of the following issues:

  • This PR has conflicts, please resolve them before merging
  • This PR is missing the 'stat: QA assured' label
  • This PR is not mergeable
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Apr 12 '24 19:04 dionisio-bot[bot]

@matheusbsilva137 lets discuss these changes in relation to the e2ee ones.

rodrigok avatar Apr 29 '24 19:04 rodrigok