Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

fix: Quote attachments are not deleted on message update

Open matheusbsilva137 opened this issue 2 years ago • 2 comments

Proposed changes (including videos or screenshots)

  • Remove old quote attachments from messages on every update.

Issue(s)

Steps to test or reproduce

There are two main test cases:

  1. Update a message to remove all of its quotes: no quote attachment should be displayed within the message after the update;
  2. Update a message to remove some of its quotes: only quote attachments related to links that are still in the message should be displayed.

This can be tested through the UI OR using the updateMessage method or chat.update endpoint.

Further comments

SUP-411

matheusbsilva137 avatar Feb 05 '24 21:02 matheusbsilva137

🦋 Changeset detected

Latest commit: 9a39e18c16dc4f30e3e9ca4d1da129cd05a8036a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 31 packages
Name Type
@rocket.chat/meteor Patch
@rocket.chat/core-typings Patch
@rocket.chat/rest-typings Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Patch
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Patch
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Patch
@rocket.chat/models Patch
@rocket.chat/ui-client Patch
@rocket.chat/ui-video-conf Patch
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Patch
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Feb 05 '24 21:02 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 54.59%. Comparing base (acd9178) to head (9a39e18).

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31660      +/-   ##
===========================================
+ Coverage    54.52%   54.59%   +0.06%     
===========================================
  Files         2290     2290              
  Lines        50315    50314       -1     
  Branches     10271    10269       -2     
===========================================
+ Hits         27435    27467      +32     
+ Misses       20385    20360      -25     
+ Partials      2495     2487       -8     
Flag Coverage Δ
e2e 53.54% <ø> (+0.05%) :arrow_up:
e2e-api 40.07% <100.00%> (+0.10%) :arrow_up:
unit 76.47% <100.00%> (+0.01%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Feb 05 '24 21:02 codecov[bot]