Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

feat: Increase the limit of members that can be added using the autojoin feature in a team's channel

Open Gustrb opened this issue 2 years ago • 3 comments

Proposed changes (including videos or screenshots)

There existed an implicit limit of 50 members that would be included whenever a a channel with auto join was created inside a team, this task ties the limit to the API_Users_Limit setting, so it is configurable.

Issue(s)

Steps to test or reproduce

This task requires a team with over 1000 members, so all of these members should be created and associated with the team

  1. Create a channel from the team
  2. Open the kebab-menu and mark the auto join box All the members should've been added correctly
  3. Add one more user to the team
  4. Create a new channel in the team
  5. Mark the auto join box Now the new user should not have been added since there is a hard limit of 1000 members

Further comments

SUP-34

Gustrb avatar Jan 11 '24 13:01 Gustrb

🦋 Changeset detected

Latest commit: 16b75cbc69a09b72cc96764762ef514d1e1ce6da

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 30 packages
Name Type
@rocket.chat/meteor Minor
@rocket.chat/core-typings Minor
@rocket.chat/rest-typings Minor
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/api-client Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/ddp-client Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/models Patch
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/uikit-playground Patch
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Jan 11 '24 13:01 changeset-bot[bot]

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 49.54%. Comparing base (6f72f4c) to head (16b75cb). Report is 180 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           develop   #31423      +/-   ##
===========================================
- Coverage    49.58%   49.54%   -0.05%     
===========================================
  Files         3316     3324       +8     
  Lines        81542    81838     +296     
  Branches     16722    16896     +174     
===========================================
+ Hits         40431    40543     +112     
- Misses       36409    36536     +127     
- Partials      4702     4759      +57     
Flag Coverage Δ
e2e 53.18% <40.00%> (-0.03%) :arrow_down:
e2e-api 40.66% <80.00%> (-0.03%) :arrow_down:
unit 76.47% <ø> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Jan 11 '24 13:01 codecov[bot]

For sure @MarcosSpessatto, just found out there were comments in JIRA. I will add the warning

Gustrb avatar Jan 11 '24 16:01 Gustrb

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

kodiakhq[bot] avatar Feb 28 '24 17:02 kodiakhq[bot]