Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

feat!: Add permissions to create rooms in teams

Open matheusbsilva137 opened this issue 2 years ago • 6 comments

Proposed changes (including videos or screenshots)

  • Add create-team-channel and create-team-group permissions to provide more control for the creation of rooms inside teams (the new permissions are checked within the team's main room scope);
  • Update client to use the new permissions within the team's main room scope;
  • Fix client to use existing team rooms' editing permissions within the team's main room scope (since auto-join and "remove team channel" options were being incorrectly displayed to room owners that are not team owners/moderators).

Issue(s)

Steps to test or reproduce

Further comments

This is a BREAKING CHANGE SUP-356

matheusbsilva137 avatar Nov 30 '23 18:11 matheusbsilva137

🦋 Changeset detected

Latest commit: 5e395a5cb6ff13bf61778bfb60034ff5937d06a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Nov 30 '23 18:11 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release-7.0.0@286e1e0). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #31117   +/-   ##
================================================
  Coverage                 ?   74.79%           
================================================
  Files                    ?      467           
  Lines                    ?    20641           
  Branches                 ?     5262           
================================================
  Hits                     ?    15439           
  Misses                   ?     4590           
  Partials                 ?      612           
Flag Coverage Δ
unit 74.79% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Nov 30 '23 18:11 codecov[bot]

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

kodiakhq[bot] avatar Jan 15 '24 15:01 kodiakhq[bot]

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

kodiakhq[bot] avatar Feb 05 '24 14:02 kodiakhq[bot]

This PR currently has a merge conflict. Please resolve this and then re-add the ['stat: ready to merge', 'automerge'] label.

kodiakhq[bot] avatar Apr 01 '24 17:04 kodiakhq[bot]

Looks like this PR is ready to merge! 🎉 If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Apr 11 '24 19:04 dionisio-bot[bot]

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-31117/ on branch gh-pages at 2024-10-16 19:21 UTC

github-actions[bot] avatar Oct 08 '24 01:10 github-actions[bot]