Rocket.Chat icon indicating copy to clipboard operation
Rocket.Chat copied to clipboard

chore!: remove unused oauth setting

Open hugocostadev opened this issue 2 years ago β€’ 6 comments

Proposed changes (including videos or screenshots)

The settings Accounts_OAuth_Custom_Button_Label_Color , Accounts_OAuth_Custom_Button_Color , *_button_label_color and *_button_color was not being used anymore for oauth buttons

Issue(s)

Steps to test or reproduce

Further comments

https://rocketchat.atlassian.net/browse/SUP-395

hugocostadev avatar Nov 29 '23 13:11 hugocostadev

πŸ¦‹ Changeset detected

Latest commit: 8f9dd46e89f3e2b5e8e019476a788573fba8a506

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 35 packages
Name Type
@rocket.chat/meteor Major
@rocket.chat/core-typings Major
@rocket.chat/rest-typings Major
@rocket.chat/uikit-playground Patch
@rocket.chat/api-client Patch
@rocket.chat/apps Patch
@rocket.chat/core-services Patch
@rocket.chat/cron Patch
@rocket.chat/ddp-client Patch
@rocket.chat/freeswitch Patch
@rocket.chat/fuselage-ui-kit Major
@rocket.chat/gazzodown Major
@rocket.chat/livechat Patch
@rocket.chat/model-typings Patch
@rocket.chat/ui-contexts Major
@rocket.chat/account-service Patch
@rocket.chat/authorization-service Patch
@rocket.chat/ddp-streamer Patch
@rocket.chat/omnichannel-transcript Patch
@rocket.chat/presence-service Patch
@rocket.chat/queue-worker Patch
@rocket.chat/stream-hub-service Patch
@rocket.chat/license Patch
@rocket.chat/omnichannel-services Patch
@rocket.chat/pdf-worker Patch
@rocket.chat/presence Patch
rocketchat-services Patch
@rocket.chat/network-broker Patch
@rocket.chat/models Patch
@rocket.chat/ui-avatar Major
@rocket.chat/ui-client Major
@rocket.chat/ui-video-conf Major
@rocket.chat/ui-voip Major
@rocket.chat/web-ui-registration Major
@rocket.chat/instance-status Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

changeset-bot[bot] avatar Nov 29 '23 13:11 changeset-bot[bot]

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Please upload report for BASE (release-7.0.0@e59d783). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##             release-7.0.0   #31102   +/-   ##
================================================
  Coverage                 ?   74.79%           
================================================
  Files                    ?      467           
  Lines                    ?    20641           
  Branches                 ?     5262           
================================================
  Hits                     ?    15439           
  Misses                   ?     4590           
  Partials                 ?      612           
Flag Coverage Ξ”
unit 74.79% <ΓΈ> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

codecov[bot] avatar Nov 29 '23 13:11 codecov[bot]

how about a migration to delete? otherwise old instances will show the setting with no translations

Good idea! I'll work on that! Thanks πŸš€

hugocostadev avatar Apr 01 '24 13:04 hugocostadev

Looks like this PR is ready to merge! πŸŽ‰ If you have any trouble, please check the PR guidelines

dionisio-bot[bot] avatar Apr 11 '24 13:04 dionisio-bot[bot]

/bark

ggazzo avatar Apr 15 '24 18:04 ggazzo

AU AU

dionisio-bot[bot] avatar Apr 15 '24 18:04 dionisio-bot[bot]

PR Preview Action v1.4.8 :---: :rocket: Deployed preview to https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-31102/ on branch gh-pages at 2024-10-16 12:42 UTC

github-actions[bot] avatar Oct 16 '24 00:10 github-actions[bot]