Rocket.Chat
Rocket.Chat copied to clipboard
[FIX] IPostMessageReacted return field named isReacted instead isRemoved
Proposed changes
- AppsEngine have
IPostMessageReacted, Handler for after a message get a reaction or a reaction got removed . has methodexecutePostMessageReactedwhich takes one of the parameter of typeIMessageReactionContextwhich includes isReacted field to know whether the emoji has been added or deleted. But Previously everytime if we react with emoji in messages instead of having abooleanvalue in isReacted field, we were gettingundefined. Reason for having value asundefinedeverytime previously was from RocketChat, we are returning the field named isRemoved instead of isReacted, which is fixed.
Issue(s)
- closes #27497
Steps to test or reproduce
Further comments
Codecov Report
Merging #27561 (84540f3) into develop (a0f4950) will increase coverage by
0.05%. The diff coverage isn/a.
:exclamation: Current head 84540f3 differs from pull request most recent head 6f39bcf. Consider uploading reports for the commit 6f39bcf to get more accurate results
@@ Coverage Diff @@
## develop #27561 +/- ##
===========================================
+ Coverage 41.58% 41.63% +0.05%
===========================================
Files 826 826
Lines 16948 16948
Branches 2074 2074
===========================================
+ Hits 7048 7057 +9
+ Misses 9620 9617 -3
+ Partials 280 274 -6
| Flag | Coverage Δ | |
|---|---|---|
| e2e | 41.63% <ø> (+0.05%) |
:arrow_up: |
Flags with carried forward coverage won't be shown. Click here to find out more.